Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Switch to identifying contracts by full path #1296

Merged

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Nov 28, 2019

The build in 855c2ad failed due to corrupted JSON artifacts. This was caused by writing the artifacts of two separate contracts into the same file concurrently, which itself was caused by using the basename instead of the full path to the Solidity files.

@spalladino spalladino merged commit 396fc54 into OpenZeppelin:master Nov 29, 2019
@frangio frangio deleted the fix-compile-for-duplicate-basenames branch November 29, 2019 17:14
@nventuro
Copy link
Contributor

How is this related to #1203? Will the second contract overwrite the first one?

@frangio
Copy link
Contributor Author

frangio commented Nov 30, 2019

I'm not sure it's related and I don't think we've fixed the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants