Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Warn when importing vanilla contracts package #1335

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

spalladino
Copy link
Contributor

Users should only install contracts from oz/contracts-eth-package, not oz/contracts. Warn about this when an import for the vanilla contracts package is found.

Fixes #1297

Users should only install contracts from oz/contracts-eth-package, not oz/contracts. Warn about this when an import for the vanilla contracts package is found.
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I got a bit lost in the flow of when the validations are done, and how they reach the validation logger. But the implementation seems good.

packages/lib/src/validations/VanillaContracts.ts Outdated Show resolved Hide resolved
packages/lib/src/validations/VanillaContracts.ts Outdated Show resolved Hide resolved
@spalladino
Copy link
Contributor Author

@frangio updated!

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio added the status:ready-to-merge Order mergify to merge label Dec 17, 2019
@frangio frangio merged commit 3f2dd99 into master Dec 17, 2019
@frangio frangio deleted the feature/warn-on-vanilla-contracts-#1297 branch December 17, 2019 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready-to-merge Order mergify to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when creating a contract importing from @openzeppelin/contracts
2 participants