This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Store relative paths in project file #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Jan 13, 2020
| @@ -84,7 +84,8 @@ export default class ProjectFile { | |||
| } | |||
|
|
|||
| public get root(): string { | |||
| return path.dirname(this.filePath); | |||
| // We go to the parent of the containing directory (.openzeppelin) to get the root | |||
| return path.dirname(path.dirname(this.filePath)); | |||
There was a problem hiding this comment.
I don't think this is correct as long as we support the old zos.json. Or is migration mandatory?
There was a problem hiding this comment.
Good catch! Just force pushed a fix. By the way, only after I pushed it I noted I shouldn't have amended, so you could see the new diff. Apologies for that! Still, being a small change, I hope you won't mind!
spalladino
force-pushed
the
fix/relative-project-paths-#1372
branch
from
073ac1c
to
0bb4650
Compare
frangio
approved these changes
Jan 20, 2020
Co-Authored-By: Francisco Giordano <[email protected]>
spalladino
added
status:ready-to-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372