Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Update firebase dependency #1450

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Update firebase dependency #1450

merged 1 commit into from
Feb 11, 2020

Conversation

spalladino
Copy link
Contributor

Updates grpc transitive dependency, which was causing install issues in node 13

Fixes #1419

Updates grpc transitive dependency, which was causing install issues in node 13

Fixes #1419
@spalladino
Copy link
Contributor Author

I manually tested the push to firebase and it worked fine. I'm doing this PR on release 2.7 so we can release a 2.7.1 with this fix.

@frangio
Copy link
Contributor

frangio commented Feb 11, 2020

Shouldn't this be merged to master?

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spalladino spalladino merged commit 55b3d65 into release/2.7 Feb 11, 2020
@spalladino spalladino deleted the dep/grpc-1.24 branch February 11, 2020 15:31
frangio pushed a commit that referenced this pull request Feb 18, 2020
Updates grpc transitive dependency, which was causing install issues in node 13

Fixes #1419

(cherry picked from commit 55b3d65)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants