This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Add support for solidity-coverage #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still looking into the failing tests and comparing the coverage results with the master build of the contracts repo, but the bulk of the required changes is already here. |
|
All done! This commit now replicates the behavior of the coverage run on the contracts repo (the same tests fail and for the same reasons). |
ylv-io
approved these changes
Nov 15, 2019
| @@ -0,0 +1,9 @@ | |||
| import colors from 'ansi-colors'; | |||
|
|
|||
| export function log(msg: string): void { | |||
There was a problem hiding this comment.
Really like putting it in a separate file as soon as possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running coverage requires using a special version of ganache-core (forked in https://github.com/OpenZeppelin/ganache-core-coverage), which due to the extensive build process, we consume already packed and published as a GitHub release (which I made by running
npm pack).When running under coverage mode, we use that special ganache version and enable the
allowUnlimitedContractSizeandemitFreeLogs, which reduce the side effects of the coverage instrumentation, as well as override user supplied configuration for gas values so that tests don't start failing due to side effects of coverage. This allows users to have a single config file that does not need to be modified when running a coverage run.edit: I also pinned the web3 version in this PR (see web3/web3.js#3210) because it was breaking the package, sorry for having that here