Allow assignment of immutable variables #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
commented
Jul 5, 2023
ericglau
approved these changes
Jul 7, 2023
packages/core/src/validate/report.ts
Outdated
| msg: e => `Variable \`${e.name}\` is immutable and will be initialized on the implementation`, | ||
| hint: () => | ||
| `If by design, annotate with '@custom:oz-upgrades-unsafe-allow state-variable-immutable'\n` + | ||
| `Otherwise, use a mutable variable instead`, |
There was a problem hiding this comment.
Why is "use a constant" no longer one of the suggestions?
There was a problem hiding this comment.
No strong reason, I've added it back.
|
Can you also update the changelog in core? |
ericglau
approved these changes
Jul 9, 2023
|
@ericglau Let's merge this and release this when you can. I want to make the equivalent change in the transpiler (override flags are used to control transpilation). |
|
@frangio Released in @openzeppelin/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment to immutable variables currently requires both overrides
state-variable-immutableandstate-variable-assignment. I believe the second one should be implicit. Assignment is a problem when it's in storage.