Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(erc20): implement Metadata extension #20

Merged
merged 4 commits into from
Apr 1, 2024
Merged

feat(erc20): implement Metadata extension #20

merged 4 commits into from
Apr 1, 2024

Conversation

alexfertel
Copy link
Contributor

@alexfertel alexfertel commented Mar 28, 2024 •
edited
Loading

Resolves #29

PR Checklist

  • Tests
  • Documentation
    • Will be finished in a separate PR.

@alexfertel alexfertel added priority: 2 We will resolve this in a short timeframe. type: feature New feature request. effort: low Easy or tiny task that takes less than a day. labels Mar 28, 2024
@alexfertel alexfertel added this to the Release v0.1.0 milestone Mar 28, 2024
@alexfertel alexfertel self-assigned this Mar 28, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 375b5db
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66068cb3d0d3bf00089f750f

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.22222% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 92.9%. Comparing base (1c4b23b) to head (375b5db).
Report is 2 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
contracts/src/erc20/mod.rs 87.5% <100.0%> (-0.1%) ⬇️
contracts/src/erc20/extensions/metadata.rs 81.8% <81.8%> (ø)

bidzyyys
bidzyyys previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

contracts/Cargo.toml Show resolved Hide resolved
contracts/src/erc20/extensions/metadata.rs Outdated Show resolved Hide resolved
bidzyyys
bidzyyys approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

contracts/Cargo.toml Show resolved Hide resolved
qalisander
qalisander approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

contracts/src/erc20/extensions/metadata.rs Show resolved Hide resolved
@alexfertel alexfertel merged commit 3df4d8a into main Apr 1, 2024
18 checks passed
@alexfertel alexfertel deleted the erc20-metadata branch April 1, 2024 10:39
@bidzyyys bidzyyys mentioned this pull request Apr 3, 2024
Closed
@alexfertel alexfertel mentioned this pull request Apr 9, 2024
Merged
@alexfertel alexfertel removed this from the Release v0.1.0 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qalisander qalisander qalisander approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

Assignees

@alexfertel alexfertel

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will resolve this in a short timeframe. type: feature New feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC-20 Metadata
3 participants
@alexfertel @bidzyyys @qalisander