Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upgrade electron-builder): to ^23.0.2 #10266

Closed
wants to merge 1 commit into from

Conversation

y3rsh
Copy link
Collaborator

@y3rsh y3rsh commented May 11, 2022

Overview

yarn upgrade electron-builder@^23.0.2

Developers with arm64 mac may not make -C app-shell dist-osx

Risk assessment

Low

arm64 mac users may make -C app-shell dist-osx
@y3rsh y3rsh requested a review from a team as a code owner May 11, 2022 12:44
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #10266 (b3275ec) into edge (e21d8db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #10266   +/-   ##
=======================================
  Coverage   74.73%   74.73%           
=======================================
  Files        2107     2107           
  Lines       55464    55464           
  Branches     5623     5623           
=======================================
  Hits        41450    41450           
  Misses      12853    12853           
  Partials     1161     1161           
Flag Coverage Δ
app 71.44% <ø> (ø)
components 52.82% <ø> (ø)
labware-library 49.74% <ø> (ø)
protocol-designer 45.13% <ø> (ø)
react-api-client 82.48% <ø> (ø)
step-generation 86.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@y3rsh y3rsh closed this May 11, 2022
@y3rsh y3rsh reopened this May 11, 2022
@y3rsh y3rsh closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant