Skip to content

Commit

Permalink
Update migration guide and envariable some values to avoid changing them
Browse files Browse the repository at this point in the history
  • Loading branch information
louismaximepiton committed Jul 27, 2023
1 parent cbe8292 commit 1d48c99
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
10 changes: 5 additions & 5 deletions site/assets/scss/_scrolling.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@ main {
h3,
h4,
[tabindex="0"] {
scroll-margin-top: 7.5rem;
scroll-margin-top: add($offset-top, .5rem);
scroll-margin-bottom: 100px;

@include media-breakpoint-up(md) {
scroll-margin-top: 11rem;
scroll-margin-top: add($offset-top, 4rem);

.header-minimized ~ .bd-gutter & {
scroll-margin-top: 8.5rem;
scroll-margin-top: add($offset-top, 1.5rem);
}
}

@include media-breakpoint-up(lg) {
scroll-margin-top: 10rem;
scroll-margin-top: add($offset-top, 2.5rem);

.header-minimized ~ .bd-gutter & {
scroll-margin-top: 7.5rem;
scroll-margin-top: $offset-top;
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions site/content/docs/5.3/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ If you need more details about the changes, please refer to the [v5.3.2 release]
- **Orange navbar**
- <span class="badge bg-warning">Warning</span> The minimizing behavior with `.header-minimized` is applied to the `<header>` instead of one of its children directly.

### Additional changes

- **Removed default scroll padding behavior. —** This led to an unintended scroll of the page while tabbing inside the navbar in certain browsers. To keep it enable in your websites, set `$enable-fixed-header: true;` before importing Boosted variables. Another solution to this problem is used inside Boosted documentation. Please refer to [this scrolling CSS file]({{< param repo >}}/blob/main/site/assets/scss/_scrolling.scss) to know more about this.

## v5.3.1

<hr class="mb-4">
Expand Down

0 comments on commit 1d48c99

Please sign in to comment.