Fix feedback

Orange-OpenSource · Sep 19, 2023 · 7507bee · 7507bee
1 parent 12224b0
commit 7507bee
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/scss/_alert.scss b/scss/_alert.scss
@@ -82,8 +82,8 @@
     --#{$prefix}alert-border-color: var(--#{$prefix}#{$state}-border-subtle);
     // Boosted mod: no `--#{$prefix}alert-link-color`
     // Boosted mod
-    @if type-of(map-get($alert-icons, $state)) == "map" {
-      --#{$prefix}alert-icon-bg-image: #{map-get(map-get($alert-icons, $state), "icon")};
+    @if type-of(map-get($alert-icons, $state)) == "list" {
+      --#{$prefix}alert-icon-bg-image: #{nth(map-get($alert-icons, $state), 1)};
 
       .alert-icon::before {
         background: var(--#{$prefix}alert-icon-bg-image) no-repeat top left / var(--#{$prefix}alert-logo-size);

diff --git a/scss/_variables.scss b/scss/_variables.scss
@@ -1949,11 +1949,13 @@ $alert-border-width:                var(--#{$prefix}border-width) !default;
 
 // Boosted mod
 $alert-padding-sm:                  $spacer * .5 !default;
-// Know that using a map for the icon will avoid color change
 $alert-icons: (
   "success": var(--#{$prefix}success-icon),
   "info":    escape-svg($info-icon),
-  "warning": ("icon":   escape-svg($warning-icon)),
+  // Create a list for this warning icon to indicate that the mask needs to be replaced by a background image
+  // Be aware that the background of the icon won't change anymore
+  // Note: `true` parameter is only used to create a list, it could be empty (e.g. `(escape-svg($warning-icon),)`)
+  "warning": (escape-svg($warning-icon), true),
   "danger":  var(--#{$prefix}error-icon)
 ) !default;
 $alert-logo-size:                   add($spacer * .5, 1rem) !default;

diff --git a/site/content/docs/5.3/migration.md b/site/content/docs/5.3/migration.md
@@ -49,7 +49,6 @@ If you need more details about the changes, please refer to the [v5.3.2 release]
     <summary><span class="badge bg-success">New</span> CSS variables:</summary>
     <ul>
       <li><code>--bs-accordion-btn-hover-bg</code></li>
-      <li><code>--bs-alert-icon-bg</code></li>
       <li><code>--bs-local-nav-active-bg</code></li>
       <li><code>--bs-local-nav-active-color</code></li>
       <li><code>--bs-local-nav-active-marker-width</code></li>