Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Variables for all components #1196

Closed
65 of 75 tasks
louismaximepiton opened this issue Apr 6, 2022 · 1 comment
Closed
65 of 75 tasks

CSS Variables for all components #1196

louismaximepiton opened this issue Apr 6, 2022 · 1 comment

Comments

@louismaximepiton
Copy link
Member

louismaximepiton commented Apr 6, 2022

Process

  • Choose one use case in this list, please write your pseudo next to the point you take
  • Create a branch and a PR for this use case
  • In this list, add at the end of the corresponding line a link to the PR
  • When the PR is merged, check the use case in the list

Note: Please try to avoid creating a PR that handles several use cases at the same time; it will be easier to track the use cases and easier for the reviewers with small PRs.

When all the checkboxes are checked, this issue can be closed.

Proposal

We need to improve our components and our modifications to use CSS variables such as Bootstrap. However, we could trim the unused variables to reduce our package size. Here is the issue tracking what are the remaining components :

Motivation and context

Be closer to Bootstrap and add more flexibility to our framework.

@julien-deramond
Copy link
Member

I'll try to update the list when things will come back from Bootstrap.

@julien-deramond julien-deramond changed the title Tracking: CSS Variables in Components CSS Variables for all components May 4, 2022
@isabellechanclou isabellechanclou linked a pull request May 11, 2022 that will close this issue
@louismaximepiton louismaximepiton self-assigned this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants