Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for alerts #1165

Merged
merged 8 commits into from
Jun 10, 2022
Merged

Fixes for alerts #1165

merged 8 commits into from
Jun 10, 2022

Conversation

louismaximepiton
Copy link
Member

Proposal to fix v4 -> v5.

  • Docs > Components > Alerts Sizes: remove margin when stacked? (no design specs).
    • divide by 2 the margin, could maybe be reduced more ?
  • Docs > Components > Alerts Missing specific Boosted message about the icons from v4.
    • Added the same as v4 one.
  • Docs > Components > Alerts Missing specific Boosted message about the div in "Additional content"
    • Added the same as v4 one.

scss/_alert.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@netlify
Copy link

netlify bot commented May 31, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f5a3894
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62a2ef47fecb1f00098b67b6
😎 Deploy Preview https://deploy-preview-1165--boosted.netlify.app/docs/5.1/components/alerts
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@louismaximepiton louismaximepiton deleted the main-lmp-alert-fixes branch June 1, 2022 14:46
@julien-deramond

This comment was marked as outdated.

@louismaximepiton louismaximepiton restored the main-lmp-alert-fixes branch June 2, 2022 06:19
@julien-deramond julien-deramond merged commit c1d5dae into main Jun 10, 2022
@julien-deramond julien-deramond deleted the main-lmp-alert-fixes branch June 10, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants