Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve popover's arrow appearance #1922

Closed
3 tasks done
MewenLeHo opened this issue Mar 27, 2023 · 1 comment · Fixed by #1936
Closed
3 tasks done

Improve popover's arrow appearance #1922

MewenLeHo opened this issue Mar 27, 2023 · 1 comment · Fixed by #1936
Assignees
Labels

Comments

@MewenLeHo
Copy link
Contributor

MewenLeHo commented Mar 27, 2023

Prerequisites

Describe the issue

Coming from #1803

The width of the border's arrow seems thiner and is missing 1 (or 2?) px.

It seems not related to the way CSS handle diagonal lines.

227134473-d00b5519-c02f-454b-9204-f88cce6715f5

Reduced test cases

A solution can be to play with ::before (probably not the left/right values), and the border widths because the "white area" is too large and hides 1px from the 2px border of the arrow.

What operating system(s) are you seeing the problem on?

Windows, macOS

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of Boosted are you using?

v5.3.0

@MewenLeHo MewenLeHo added the bug label Mar 27, 2023
@louismaximepiton
Copy link
Member

Already talked about this here,

Maybe a good solution would be bottom: round(calc(var(--bs-popover/tooltip-border-width) * sqrt(2))); ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants