Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltips and popover design according to UI Kit v5 #1803

Merged

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Jan 25, 2023

Related issues

Closes #1594

Description

Update tooltips and popovers design.

Motivation & Context

Compliance to UI Kit v5.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Tooltips: https://deploy-preview-1803--boosted.netlify.app/docs/5.3/components/tooltips/
Popovers: https://deploy-preview-1803--boosted.netlify.app/docs/5.3/components/popovers/#four-directions

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 196b3ac
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64217351ef1ff300087cc754
😎 Deploy Preview https://deploy-preview-1803--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo MewenLeHo marked this pull request as draft January 25, 2023 14:14
@MewenLeHo MewenLeHo marked this pull request as ready for review January 30, 2023 09:24
louismaximepiton

This comment was marked as outdated.

@MewenLeHo MewenLeHo force-pushed the main-mlh-update-tooltips-popover-design-new-ui-kit branch from 9b2846a to 92c4b03 Compare February 10, 2023 10:29
@MewenLeHo

This comment was marked as outdated.

@MewenLeHo MewenLeHo marked this pull request as draft February 16, 2023 12:38
@MewenLeHo MewenLeHo marked this pull request as ready for review February 16, 2023 14:22
@julien-deramond
Copy link
Member

Is it an optical effect or the width of the border's arrow is missing 1 or 2 px? macOS + Firefox here

Might have found a solution by playing with ::before, the left/right values, and the border widths. But let's tackle it after having merged this PR. It's gonna be easier to review and to modify.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things

scss/_popover.scss Show resolved Hide resolved
scss/_popover.scss Show resolved Hide resolved
scss/_popover.scss Outdated Show resolved Hide resolved
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @louismaximepiton I let you finalize your review as well and after that, let's :shipit:

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks fine to me, well done!

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond added v5 and removed v5 labels Mar 27, 2023
@julien-deramond julien-deramond merged commit c8fb697 into main Mar 27, 2023
@julien-deramond julien-deramond deleted the main-mlh-update-tooltips-popover-design-new-ui-kit branch March 27, 2023 10:52
@isabellechanclou
Copy link
Member

Decided in daily:

  • Keep this "Custom popover" section.
  • Restore the "Custom button" one (to do in an other PR)
  • Add a design callout message (in this PR if not already done in PR docs: add design callouts in all the documentation when incompatibility with ODS #1614)
  • Keep the custom padding-bottom of 10px (instead of 20px specified by Orange designers) that illustrates how this component can be custom
  • To emphasize the customization, the orange color used for the borders and the background title part will be replaced by an other one (we thought of using Bootstrap's purple). Depending on the purple, the text color might be changed to white instead of black to ensure a satisfying text/background color contrast. We intend to use this same color on each custom variant of Boosted component. A PR will be made to Bootstrap to ask them to do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand component docs Improvements or additions to documentation passed design review v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Components > Tooltip > Directions: Fix tooltips margins
5 participants