Dark texts #1038
Dark texts #1038
Conversation
louismaximepiton
force-pushed
the
main-lmp-dark-texts
branch
from
00e6ddf
to
9f13c7e
Compare
|
Added some examples to test the limits with b0ea83c. |
|
Sounds rather good to me. Some edge cases:
|
|
@yannickcornaille or @Lausselloic, anything to add before we begin to clean up this PR? |
|
All this suits me. |
There was a problem hiding this comment.
Not 100% sure about this solution but this is the best option found so far.
@Lausselloic Does your spider-sense warn you about something or can I merge? (after having fixed pa11y issues of course)
There was a problem hiding this comment.
solution sounds quite good for me. Maybe some adjustment need to be done.
Don't know if @ffoodd have an advice on `[class*="..."] selector? Is there any performance issues or warning?
|
Nope, however Bootstrap's stylelint config will warn you about it. I personnally prefer attribute selector to overuse classes. 👌 |
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
julien-deramond
force-pushed
the
main-lmp-dark-texts
branch
from
bbea861
to
fc5242b
Compare
I tried to manage all cases in that few lines, feel free to debate or try some things on this branch about dark texts. Need to see about
.bg-whiteinto a.bg-dark.Preview : No preview at the moment, just add
.bg-darkto<body>.Solutions tested :
Need to addTested and not concluant atm, maybe to see with a:not([class*="bg-"])? (to get[class*="-dark"] :not([class*="bg-"]) {}):hasin the future (when implmented) ?Need to see if there is some rollback to do on carousel, dropdowns and so on ?