Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing attribute in global header standard example #1662

Merged

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Nov 25, 2022

Related issues

The attribute aria-current="page" was used in the code example:

code_with_attribute

but was missing from the associated HTML code:

screenshot-boosted orange com-2022 11 25-18_21_34

Description

Add missing attribute.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@MewenLeHo MewenLeHo added v5 docs Improvements or additions to documentation fix labels Nov 25, 2022
@MewenLeHo MewenLeHo self-assigned this Nov 25, 2022
@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 4f12491
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6384b1943544ed0009234651
😎 Deploy Preview https://deploy-preview-1662--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please update https://deploy-preview-1662--boosted.netlify.app/docs/5.2/components/orange-navbar/#navigation-under where there's a missing aria-current="page" as well.

@louismaximepiton
Copy link
Member

Same for right part of supra bar in https://deploy-preview-1662--boosted.netlify.app/docs/5.2/components/orange-navbar/#responsive-behavior ! Missing aria-current="true"

@MewenLeHo MewenLeHo force-pushed the main-mlh-fix-missing-attribute-in-header-example branch from 79be1dd to 57b675f Compare November 28, 2022 08:09
@MewenLeHo MewenLeHo force-pushed the main-mlh-fix-missing-attribute-in-header-example branch from 2d3d0a4 to f053a5f Compare November 28, 2022 08:58
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond merged commit f9ae2ac into main Nov 28, 2022
@julien-deramond julien-deramond deleted the main-mlh-fix-missing-attribute-in-header-example branch November 28, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-reply docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants