Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orange navbar: change minimizing behavior #1830

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Orange navbar: change minimizing behavior #1830

merged 10 commits into from
Jul 27, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 14, 2023 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Might interfer with #1274.

Description

Apply the class .minized-header to the header and not to the navbar directly.

Motivation & Context

Might help people building some custom CSS for the header.
Seems more logical to me.

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 js Pull requests that update Javascript code docs Improvements or additions to documentation css enhancement labels Feb 14, 2023
@louismaximepiton louismaximepiton self-assigned this Feb 14, 2023
@netlify
Copy link

netlify bot commented Feb 14, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 4a9fc4b
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64c270bb925aab0009f4f3c6
😎 Deploy Preview https://deploy-preview-1830--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review March 9, 2023 16:04
@MewenLeHo MewenLeHo self-requested a review March 16, 2023 08:46
MewenLeHo
MewenLeHo reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS part seems ok to me.
The CSS part too even if one of the incoming commit from Bootstrap will make it unnecessary.

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MewenLeHo
MewenLeHo approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still ok since last review.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

julien-deramond
julien-deramond approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond julien-deramond merged commit efee64e into main Jul 27, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-lmp-better-scroll-target branch July 27, 2023 13:30
@julien-deramond julien-deramond mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@MewenLeHo MewenLeHo MewenLeHo approved these changes

Assignees

@louismaximepiton louismaximepiton

Labels
css docs Improvements or additions to documentation enhancement js Pull requests that update Javascript code v5
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louismaximepiton @julien-deramond @MewenLeHo