Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v4.4.1 #285

Merged
merged 91 commits into from
Feb 10, 2020
Merged

Prepare v4.4.1 #285

merged 91 commits into from
Feb 10, 2020

Conversation

ffoodd
Copy link
Contributor

@ffoodd ffoodd commented Jan 13, 2020

  • Run linters;
  • Run compilers;
  • Run tests;
  • Check documentation site: examples and contents;
  • Test cross-browser compatibility locally and with BrowserStack:
    • Firefox ESR
    • IE11
    • Latest Edge, Chrome, Firefox, Safari
    • iOS Safari
    • Chrome & Firefox on Android
  • Including RTL mode;
  • Ask for reviews and accessibility testing;
  • npm run release-version to bump version number
  • npm run release to compile dist, update SRI hashes in doc and package the release
  • Prepare changelog:
  • Wait for brand approval or suggestions about current items in navigation
  • implement changes (in components, Boostwtach, examples…)
  • re-run npm run release
  • update Ship List + changelog

Then:

  • commit and push dist with a chore(release) commit message
  • merge (on v4-dev for now)
  • tag your version
  • create a GitHub release:
    • attach zip file
    • paste CHANGELOG in the release's description
  • publish documentation on gh-pages
    • copy _gh_pages/ top level files (index.html, redirects.json, sitemap.xml…) and _gh_pages/docs/4.4 to the gh-pages branch
    • ensure Algolia indexes new release content (probably requires a PR)
  • npm pack then npm publish
  • publish on Nuget
  • check release on NPM, Nuget, Packagist

Close #287 on merge.

@ffoodd ffoodd added the v4 label Jan 13, 2020
@ffoodd ffoodd self-assigned this Jan 13, 2020
@ffoodd ffoodd added this to the 4.4.1 milestone Jan 16, 2020
@ffoodd
Copy link
Contributor Author

ffoodd commented Feb 7, 2020

New comments to check:

  • Reduce the height of the Supra bar by 2px to 40px.
  • Language selector arrow should be smaller (10px by 5px)
  • Align the first navigation label ‘Personal’ so it is left aligned to the Orange logo.
  • Increase the spacing between the labels in the Supra bar to 15px.
  • The space between the account icon and the language selection (in the supra bar) needs to be 30px.
  • The icons in the global header need to move up 2px.

Copy link
Member

@PigeardSylvain PigeardSylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@ffoodd ffoodd merged commit 9d71c11 into v4-dev Feb 10, 2020
@ffoodd ffoodd deleted the chore/prepare-4.4.1 branch February 10, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.4.1 — Ship list
2 participants