Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pa11y-ci from 2.42.0 to 3.0.1 #938

Merged
merged 27 commits into from
Dec 7, 2022
Merged

Bump pa11y-ci from 2.42.0 to 3.0.1 #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
111f9ae
chore(deps-dev): bump pa11y-ci from 2.42.0 to 3.0.0
julien-deramond Nov 29, 2021
507d4e4
Merge branch 'main' into main-jd-bump-pa11y-ci
louismaximepiton Nov 28, 2022
461df24
.
louismaximepiton Nov 28, 2022
21546bd
Merge branch 'main' into main-jd-bump-pa11y-ci
louismaximepiton Nov 29, 2022
13aca9e
First batch
louismaximepiton Nov 29, 2022
ceec615
Test for back-to-top + some other fixes
louismaximepiton Nov 29, 2022
09dce48
Third batch
louismaximepiton Nov 29, 2022
03960a3
Fourth batch
louismaximepiton Nov 30, 2022
cff1e8f
Fifth batch
louismaximepiton Nov 30, 2022
97d0489
Sixth batch
louismaximepiton Nov 30, 2022
c63f475
Seventh batch + test for concurrency
louismaximepiton Nov 30, 2022
09fe098
Removing the color-contrast check
louismaximepiton Dec 1, 2022
7ac12fb
Fixes for pa11y config
louismaximepiton Dec 2, 2022
512013f
.
louismaximepiton Dec 2, 2022
dea2af8
Removed some out of PR changes
louismaximepiton Dec 2, 2022
75beb3d
Remove more of them
louismaximepiton Dec 2, 2022
7baaeb8
More precise selector
louismaximepiton Dec 5, 2022
346d914
.
louismaximepiton Dec 5, 2022
a15dc28
Merge branch 'main' into main-jd-bump-pa11y-ci
louismaximepiton Dec 5, 2022
4e90bc3
Update migration guide
louismaximepiton Dec 5, 2022
af2b834
Merge branch 'main' into main-jd-bump-pa11y-ci
julien-deramond Dec 6, 2022
d271c77
Remove `role="region"` and wait for Bootstrap.
louismaximepiton Dec 6, 2022
6b5b4d5
Merge branch 'main' into main-jd-bump-pa11y-ci
julien-deramond Dec 6, 2022
6bae88f
TEMP remove a rule to make GitHub actions fail
julien-deramond Dec 6, 2022
3eb80d7
Rollback TEMP modification
julien-deramond Dec 6, 2022
4d93471
Updating migration guide
louismaximepiton Dec 7, 2022
3f2b8a0
Minor wording modification in migration note
julien-deramond Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions build/.pa11yci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@
"--no-sandbox"
]
},
"reporters": [
"cli",
["json", { "fileName": "./pa11y-ci-results.json" }]
],
"runners": [
"axe"
],
"hideElements": "[id*='tarteaucitron'], #TableOfContents, .text-primary, .accordion-button:not(.collapsed), .active, [aria-current], select:disabled, [disabled] label, [disabled] + label, .modal, .bd-example nav, .badge.rounded-pill.bg-info.text-white, a.disabled, .form-check.form-switch, .nav-tabs .nav-item .nav-link.disabled, body > div.position-fixed:last-of-type",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed selectors that became useless due to our new rules/new aXe tool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this PR will be merged, don't forget to update https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/wiki/Docs-accessibility-issues with the new content + explanation.

"useIncognitoBrowserContext": false,
"hideElements": "iframe, #text-decoration + p + div a.text-decoration-none, .accordion-collapse, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar",
"ignore": [
Copy link
Member

@louismaximepiton louismaximepiton Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New hideElements:

iframe 
Errors in http://localhost:9001/docs/5.2/helpers/ratio/:
 • Frames should be tested with axe-core (https://dequeuniversity.com/rules/axe/4.5/frame-tested?application=axeAPI)
   (html > body > div:nth-child(6) > main > div:nth-child(3) > div:nth-child(7) > div:nth-child(1) > div > iframe)
   <iframe src="https://www.youtube.com/embed/zpOULjyy-n8?rel=0" title="YouTube video" allowfullscreen=""></iframe>
a.text-decoration-none 
Errors in http://localhost:9001/docs/5.2/utilities/text/:
 • Links must be distinguishable without relying on color (https://dequeuniversity.com/rules/axe/4.5/link-in-text-block?application=axeAPI)
   (html > body > div:nth-child(6) > main > div:nth-child(3) > div:nth-child(40) > div:nth-child(1) > a)
   <a href="#" class="text-decoration-none">This link has its text decorati...</a>
⚠️#offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar

These should be removed once twbs/bootstrap#37571 is resolved.

Errors in http://localhost:9001/docs/5.2/components/offcanvas/:
 • Elements must only use allowed ARIA attributes (https://dequeuniversity.com/rules/axe/4.5/aria-allowed-attr?application=axeAPI)
   (#offcanvas)
   <div class="offcanvas offcanvas-start show" tabindex="-1" id="offcanvas" aria-labelledby="offcanvasLabel"> <div class="offcanvas-header...</div>
 • Elements must only use allowed ARIA attributes (https://dequeuniversity.com/rules/axe/4.5/aria-allowed-attr?application=axeAPI)
   (#offcanvasDark)
   <div class="offcanvas offcanvas-start show text-bg-dark" tabindex="-1" id="offcanvasDark" aria-labelledby="offcanvasDarkLabel"> <div class="offcanvas-header...</div>
 • Elements must only use allowed ARIA attributes (https://dequeuniversity.com/rules/axe/4.5/aria-allowed-attr?application=axeAPI)
   (#offcanvasResponsive)
   <div class="offcanvas-lg offcanvas-end" tabindex="-1" id="offcanvasResponsive" aria-labelledby="offcanvasResponsiveLabel"> <div class="offcanvas-header...</div>
 • Elements must only use allowed ARIA attributes (https://dequeuniversity.com/rules/axe/4.5/aria-allowed-attr?application=axeAPI)
   (#bdSidebar)
   <div class="offcanvas-lg offcanvas-start" tabindex="-1" id="bdSidebar" aria-labelledby="bdSidebarOffcanvasLabel"> <div class="offcanvas-...</div>
⚠️.accordion-collapse

This should be removed depending on twbs/bootstrap#37591 results.

"heading-order",
"scrollable-region-focusable"
"color-contrast"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule remove most of the errors raised by pa11y-ci. Since we have a brand, it doesn't need to be checked each time since the most errors raised are false positive (background can't be computed so error raised).

]
}
}
Loading