Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some border width semantic tokens #106

Closed
julien-deramond opened this issue Sep 18, 2024 · 1 comment · Fixed by #108
Closed

Change some border width semantic tokens #106

julien-deramond opened this issue Sep 18, 2024 · 1 comment · Fixed by #108
Assignees
Labels
🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components)

Comments

@julien-deramond
Copy link
Member

Description

The references have changed for the border width semantic tokens.
The new semantic border width tokens are:

Name Value
border-width-none border-width-0
border-width-default border-width-25
border-width-thin border-width-25
border-width-medium border-width-50
border-width-thick border-width-75
border-width-thicker border-width-100
border-width-outside-focus border-width-50

In summary:

  • border-width-thickest doesn't exist anymore
  • border-width-medium is new
  • border-width-interactive-primary-focus doesn't exist anymore
  • border-width-outside-focus is new
  • border-width-thick has a different value
  • border-width-thicker has a different value
@pylapp pylapp self-assigned this Sep 18, 2024
pylapp added a commit that referenced this issue Sep 18, 2024
Closes #106

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp linked a pull request Sep 18, 2024 that will close this issue
9 tasks
pylapp added a commit that referenced this issue Sep 18, 2024
Closes #106

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp added a commit that referenced this issue Sep 18, 2024
Closes #106

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp added a commit that referenced this issue Sep 18, 2024
- Remove `borderWidthThichkest` and `borderWidthInteractivePrimaryFocus`
- Add `borderWidthMedium` and `borderWidthOutsideFocus`
- Update `borderWithThick` and `borderWidthThicker`

Reviewed-by: Ludovic Pinel <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
Copy link
Member

pylapp commented Sep 18, 2024

📣 New TestFlight ALPHA upload 🚀

  • Display name: OUDS Showcase ALPHA (78, 40, 9, 32, 106, 94, 87, 58, 89)
  • Version: 0.2.0
  • Build number: 1726677063
  • Build tag: fcb55ec
  • Build type: ALPHA
  • Build details (GitHub):78, 40, 9, 32, 106, 94, 87, 58, 89

This is an automated message sent with Fastlane from our CI/CD pipeline 🤘

pylapp added a commit that referenced this issue Sep 19, 2024
Released of version 0.2.0
See below the full CHANGELOG details.

Added:
- [Tests] Add UI regression tests using snapshot comparisons with *swift-snapshot-testing* tool ([#78](#78))
- [DemoApp] Display fake components for elevation rendering tests
- [Library] A theme can now override the custom font family
- [Tests] Add more unit tests for theme overriding and raw tokens controls
- [Library] Add and update raw and semantic grid tokens ([#40](#40))
- [Library] Manage regular and compact layouts for sizing and spacing tokens
- [Library] "Box shadow 0" has been defined and "elevation drag" changed
- [Doc] Create the basics of a documentation ([#9](#9))
- [Library] Add more semanttic and raw tokens for typography
- [Library] Add more semantic and raw tokens for typography, and SwiftUI API to apply them
- [Library] Computation of SwiftUI radius from Figma blur and spread values for elevation tokens
- [Library] Add elevation tokens ([#32](#32))

Changed:
- [Library] Split raws, semantics and components tokens definitions and also values, composites and type aliases
- [Showcase] Improve Fastlane alpha build notifications
- [Library] Do not store blur value in elevation semantic tokens
- [Library] Change type aliases for X and Y offsets of elevations tokens
- [Library] Update border semantic tokens values ([#106](#106))
- [Showcase] Add fake components for demo and tokens tests
- [Library] Remove spread value for elevation tokens
- [Library] Remove paragraph spacing tokens for typography
- [Library] Term "fluid" has been replaced by "adaptable" in spacing semantic tokens
- [Doc] Improve DocC documentation about tokens and views extensions
- [Doc] Add more details in release documentation
- [Library] Rename semantic token "opacityEmphasized" to "opacityStrong" ([#94](#94))
- [Library] Update value of opacity raw token "opacity800" from 0.88 to 0.80 ([#87](#87))
- [Tests] Add missing unit tests for opacity raw tokens
- [Library] "OUDSThemesCommons" product has been renamed to "OUDS"

Removed:
- [Library] Remove Z Index tokens for elevations ([#109](#109))
- [Library] Remove token "borderRadiusPill" and "borderRadiusCircle" ([#58](#58))
- [Library] "Emphasis" words have been replaced by "emphasized"
- [Library] "Box shadow" words have been removed in elevation semantic and raw tokens 

Fixed:
- [Library] Fix some typos in documentation ([#89](#89))

Acked-by: Ludovic Pinel <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
@pylapp pylapp added 🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components) labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants