[#29] Add raw tokens and semantic tokens for opacity #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
pylapp
force-pushed
the
29-tokens-opacity
branch
from
6092834
to
e9bf86d
Compare
ludovic35
requested changes
Aug 6, 2024
| /// (i.e. publicly accessible from everywhere) or _Swift enum_ which are too heavy (no needs to iterate on them, no needs to make switch/cases, | ||
| /// risks to have broken code if new values added breaking existing switch/cases). | ||
| /// | ||
| /// In the future, generating tools like _Style Dictionary_ should either follow this file template and structure or just replace values or lines. | ||
| public struct OpacityRawTokens { |
There was a problem hiding this comment.
use enum here
and update comment
This commit updates when needed the values of raw tokens and semenatic tokens for opacity. It brings also unit tests for theme overriding and raw tokens relationships. Closes #29 Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp
force-pushed
the
29-tokens-opacity
branch
from
e9bf86d
to
138fbd2
Compare
ludovic35
previously approved these changes
Aug 7, 2024
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THis commit updates when needed the values of raw tokens and semenatic tokens for opacity. It brings also unit tests for theme overriding and raw tokens relationships.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
#29
Description
Update raw and semantic tokens for opacity
Motivation & Context
See #29
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)