Make incomplete salary more generic, since it's past 2021 now #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AetherUnbound
requested review from
mpuckett159,
sarayourfriend,
sea-kelp and
vertexactual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR updates the salary condition for when the data is in complete. Previously this would show up as
year incomplete. Now that it's past 2021, the year is incomplete but the data we have is not, so I've changed this todata incomplete.Notes for Deployment
Screenshots (if appropriate)
Tests and linting
I have rebased my changes on
mainjust lintpassesjust testpasses