Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Werkzeug import error #167

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix Werkzeug import error #167

merged 1 commit into from
Aug 16, 2022

Conversation

sea-kelp
Copy link
Collaborator

@sea-kelp sea-kelp commented Aug 12, 2022

Description of Changes

Fix Werkzeug import error by upgrading Flask-Login to 0.6.2
https://stackoverflow.com/questions/73105877/importerror-cannot-import-name-parse-rule-from-werkzeug-routing

Creating openoversight_web_run    ... done
Traceback (most recent call last):
  File "/usr/src/app/OpenOversight/../create_db.py", line 2, in <module>
    from OpenOversight.app import create_app
  File "/usr/src/app/OpenOversight/app/__init__.py", line 10, in <module>
    from flask_login import LoginManager
  File "/usr/local/lib/python3.9/site-packages/flask_login/__init__.py", line 12, in <module>
    from .login_manager import LoginManager
  File "/usr/local/lib/python3.9/site-packages/flask_login/login_manager.py", line 35, in <module>
    from .utils import _create_identifier
  File "/usr/local/lib/python3.9/site-packages/flask_login/utils.py", line 14, in <module>
    from werkzeug.routing import parse_rule
ImportError: cannot import name 'parse_rule' from 'werkzeug.routing' (/usr/local/lib/python3.9/site-packages/werkzeug/routing/__init__.py)
ERROR: 1
error: Recipe `fresh-start` failed on line 55 with exit code 1

Notes for Deployment

None!

Screenshots (if appropriate)

Tests and linting

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@AetherUnbound
Copy link
Collaborator

Nice! This looks like a more future-facing approach than #166 - hopefully this works out!

@sea-kelp sea-kelp marked this pull request as ready for review August 12, 2022 05:39
@sea-kelp
Copy link
Collaborator Author

@AetherUnbound: Oh didn't see your PR! Happy to go with either solution

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants