Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit Department form #401

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix Edit Department form #401

merged 1 commit into from
Feb 5, 2024

Conversation

sea-kelp
Copy link
Collaborator

@sea-kelp sea-kelp commented Jan 4, 2024

Description of Changes

Fix #357:

  1. Fix issue where changes were not committed if department did not have associated jobs
  2. Fix "Add another rank" button

This wasn't caught by our unit tests because the Flask test client is not triggering database session rollbacks between requests, meaning that uncommitted changes persisted across multiple requests.

Notes for Deployment

None!

Screenshots (if appropriate)

N/A

Tests and linting

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@sea-kelp sea-kelp requested a review from a team as a code owner January 4, 2024 23:44
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected! That's unfortunate to hear about the testing 😭

@AetherUnbound AetherUnbound merged commit f77847b into main Feb 5, 2024
2 checks passed
@AetherUnbound AetherUnbound deleted the fix/edit-department branch February 5, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Edit Department form does not work
2 participants