Remove unnecessary external URL building for placeholder image #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I did an audit of usages of
url_for(..., _external=True)
in the project. All other uses are for JSON+LD definition of breadcrumb elements which probably explicitly require the full URL with scheme:OpenOversight/OpenOversight/app/templates/incident_detail.html
Lines 12 to 32 in 6cd9857
All other cases were for email generation which also need the full URL with scheme.
Notes for Deployment
Screenshots (if appropriate)
Tests and linting
I have rebased my changes on
main
just lint
passesjust test
passes