Use PaymentIntentId directly instead of by PaymentIntentPersistence #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarahelsaig Please review the code |
sarahelsaig
requested changes
Sep 29, 2024
src/Modules/OrchardCore.Commerce.Payment.Stripe/Abstractions/IStripePaymentService.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce.Payment.Stripe/Assets/Scripts/stripe-payment-form.js
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce.Payment/Abstractions/IPaymentProvider.cs
Outdated
Show resolved
Hide resolved
src/Modules/OrchardCore.Commerce.Payment/Controllers/PaymentController.cs
Outdated
Show resolved
Hide resolved
| @@ -94,7 +94,7 @@ Task UpdateOrderToOrderedAsync( | |||
| /// <param name="providerName">The name of provider.</param> | |||
| /// <param name="shoppingCartId">Shopping Cart.</param> | |||
| /// <returns>The list of the errors.</returns> | |||
| Task<IList<string>> ValidateErrorsAsync(string providerName, string? shoppingCartId); | |||
| Task<IList<string>> ValidateErrorsAsync(string providerName, string? shoppingCartId, string? paymentIntentId); | |||
There was a problem hiding this comment.
Here too:
Suggested change
| Task<IList<string>> ValidateErrorsAsync(string providerName, string? shoppingCartId, string? paymentIntentId); | |
| Task<IList<string>> ValidateErrorsAsync(string providerName, string? shoppingCartId, string? paymentId); |
…StripePaymentService.cs Co-authored-by: Sára El-Saig <[email protected]>
hishamco
requested changes
Sep 29, 2024
| @@ -107,7 +104,7 @@ window.stripePaymentForm = function stripePaymentForm( | |||
| }); | |||
| } | |||
|
|
|||
| const validationJson = await fetchPost(validateUrl); | |||
| const validationJson = await fetchPost(validateUrl + '/' + paymentIntentId); | |||
There was a problem hiding this comment.
Suggested change
| const validationJson = await fetchPost(validateUrl + '/' + paymentIntentId); | |
| const validationJson = await fetchPost($"{validateUrl}/{paymentIntentId}"); |
There was a problem hiding this comment.
That's not valid Javascript. 🫠
src/Modules/OrchardCore.Commerce.Payment.Stripe/Assets/Scripts/stripe-payment-form.js
Outdated
Show resolved
Hide resolved
…/stripe-payment-form.js Co-authored-by: Sára El-Saig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484