Merge branch 'ma/remove-assign-role' of https://github.com/OrchardCMS…

…/OrchardCore into ma/remove-assign-role
OrchardCMS · Sep 19, 2024 · 99998f1 · 99998f1
2 parents ca1b99a + d54ad43
commit 99998f1
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/docs/releases/2.1.0.md b/src/docs/releases/2.1.0.md
@@ -52,12 +52,12 @@ Previously, the `UsersCanRegister` property controlled which types of registrati
 
 ### Roles Feature
 
-In the Roles feature, there were previously `AssignRoles` and `AssignRole_{RoleName}` permissions, alongside `AssignRoleToUsers` and `AssignRoleToUsers_{RoleName}` permissions. As these permissions were redundant, `AssignRoles` and `AssignRole_{RoleName}` have been removed in favor of the latter.
+In the Roles feature, there were previously `AssignRoles` and `AssignRole_{RoleName}` permissions, alongside the Users feature's `AssignRoleToUsers` and `AssignRoleToUsers_{RoleName}` permissions. As these permissions were redundant and the `AssignRoles` permissions were never actually authorized against, `AssignRoles` and `AssignRole_{RoleName}` have been removed in favor of the latter.
 
-To ensure smooth transitions, a migration step has been added. Any roles previously granted `AssignRoles` will now be automatically granted `AssignRoleToUsers`. Similarly, any roles with `AssignRole_{RoleName}` will now be granted the corresponding `AssignRoleToUsers_{RoleName}` permission.
+To ensure a smooth transition, a migration step has been added. Any roles previously granted `AssignRoles` will now be automatically granted `AssignRoleToUsers`. Similarly, any roles with `AssignRole_{RoleName}` will now be granted the corresponding `AssignRoleToUsers_{RoleName}` permission.
 
-!!! note
-    Please review all your recipes and replace occurrences of `AssignRoles` with `AssignRoleToUsers`, and `AssignRole_{RoleName}` with `AssignRoleToUsers_{RoleName}`.
+!!! warning
+    Please review all your recipes and replace occurrences of `AssignRoles` with `AssignRoleToUsers`, and `AssignRole_{RoleName}` with `AssignRoleToUsers_{RoleName}`. Also note that since the `AssignRoles` permissions didn't actually work before, while this change fixes behavior and Orchard Core will now follow the intent of setting those permissions, it might be unexpected to see the restrictions governed by the be applied. Check if your administrators can still set what they should be able to.
 
 ### New **Azure Communication Services SMS** Feature