Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithField(fieldName) should assign the fieldName as the display name by default. #14570

Closed
MikeAlhayek opened this issue Oct 23, 2023 · 0 comments · Fixed by #14571
Closed

WithField(fieldName) should assign the fieldName as the display name by default. #14570

MikeAlhayek opened this issue Oct 23, 2023 · 0 comments · Fixed by #14571
Milestone

Comments

@MikeAlhayek
Copy link
Member

Is your feature request related to a problem? Please describe.

If we have the following migration

_contentDefinitionManager.AlterPartDefinition("CustomPartName", part => part
    .WithField("Description", part => part
        .OfType("TextField")
        .WithEditor("TextArea")
    )
    .WithField("Info", part => part
        .OfType("TextField")
        .WithEditor("TextArea")
    )
    .Attachable()
);

There will be two fields added to the CustomPartName. The display name of both fields will be "TextField". I think by default, we should name then the "Description" and "Info" names unless the user uses WithDisplayName("Other Description") to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants