Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language switcher in admin not working #14834

Closed
giannik opened this issue Dec 5, 2023 · 7 comments · Fixed by #14866
Closed

language switcher in admin not working #14834

giannik opened this issue Dec 5, 2023 · 7 comments · Fixed by #14866
Assignees
@hishamco
Labels
bug 🐛
Milestone
2.0

Comments

@giannik
Copy link
Contributor

giannik commented Dec 5, 2023 •
edited
Loading

With the recent code the language switcher in the admin is not working. It stays on the same language.

image

@hishamco @MikeAlhayek
@hishamco
Copy link
Member

hishamco commented Dec 5, 2023

I will check ...

@giannik
Copy link
Contributor Author

giannik commented Dec 8, 2023

@hishamco any news. can you repro?

@hishamco hishamco self-assigned this Dec 8, 2023
@hishamco
Copy link
Member

hishamco commented Dec 8, 2023

Oops, I forgot. It's on my plate now :)

@hishamco
Copy link
Member

hishamco commented Dec 8, 2023

@giannik I can reproduce the issue, I will work on it then

@hishamco
Copy link
Member

hishamco commented Dec 8, 2023

This happen due the change in the PR #14716

@hishamco hishamco mentioned this issue Dec 8, 2023
Merged
@sebastienros sebastienros added this to the 1.x milestone Dec 14, 2023
@github-actions github-actions bot mentioned this issue Jan 11, 2024
Closed
@MikeAlhayek
Copy link
Member

MikeAlhayek commented Jan 12, 2024 •
edited
Loading

@hishamco does this fix need to be part of 1.8 release or can it wait until 1.9?

@hishamco
Copy link
Member

believe it or not I need to ping you regarding this one, if there's a patch release 1.8.2 we might need to add this one because it breaks the admin culture picker

@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hishamco hishamco

Labels
bug 🐛
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Add request localization settings to the configured one OrchardCMS/OrchardCore
4 participants
@sebastienros @giannik @hishamco @MikeAlhayek