Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request localization settings to the configured one #14866

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Dec 8, 2023

Fixes #14834

@hishamco
Copy link
Member Author

hishamco commented Dec 8, 2023

@giannik you could test this PR to ensure it resolves the issue

@giannik
Copy link
Contributor

giannik commented Dec 9, 2023

@hishamco yes this fixes it.
thanks

@sebastienros
Copy link
Member

Bonus point if you can add a functional test.

@Piedone Piedone merged commit 40389c5 into main Jan 10, 2024
3 checks passed
@Piedone Piedone deleted the hishamco/request-localization-options branch January 10, 2024 01:28
@MikeAlhayek MikeAlhayek mentioned this pull request Jan 12, 2024
@bashuss
Copy link

bashuss commented Feb 28, 2024

Could this change have broken my frontend language picker? After update to 1.8.2 from 1.7.x, a necessary View cannot be found anymore. ContentCulturePickerContainer.liquid was used before (for rendering ), but this seems to have changed to ContentCulturePicker.liquid - at least, that is the one, which is missing.
The Culture Picker is part of the main-menu: LinkMenuItem with Text, no link, but box checked "Is CulturePicker"

Wenn I create ContentCulturePicker.liquid and copy the code from the other template, the page renders without exception, the picker shows, but the dropdown is empty, shows no languages.

@Piedone
Copy link
Member

Piedone commented Feb 28, 2024

That's more likely due to the various navbar changes: https://docs.orchardcore.net/en/latest/docs/releases/1.8.0/#navbar

urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

language switcher in admin not working
6 participants