Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Youtube field with a new Embedded media field #14898

Open
sebastienros opened this issue Dec 14, 2023 · 12 comments
Open

Replace Youtube field with a new Embedded media field #14898

sebastienros opened this issue Dec 14, 2023 · 12 comments
Milestone

Comments

@sebastienros
Copy link
Member

Orchard 1 has one.

https://learn.wordpress.org/tutorial/embedding-media-and-third-party-content-on-your-website/

@Piedone
Copy link
Member

Piedone commented May 21, 2024

Why though? If I'm a non-technical user and want to embed a YouTube video, then I'll be more comfortable using something that very clearly is for YT. WP has this too, as also shown in the video.

@Piedone Piedone added this to the backlog milestone May 21, 2024
@hishamco
Copy link
Member

Because we need a field for each embedded media service for example Vimeo

@Piedone
Copy link
Member

Piedone commented May 21, 2024

Then it's about adding an additional field, not replacing the YT one.

@hishamco
Copy link
Member

I think Seb means to replace the existing YouTube field a generic one, right?

@Piedone
Copy link
Member

Piedone commented May 21, 2024

Yes, and hence I'm saying #14898 (comment).

Copy link
Contributor

github-actions bot commented Jun 8, 2024

It seems that this issue didn't really move for quite a while despite us asking the author for further feedback. Is this something you'd like to revisit any time soon or should we close? Please reply.

@github-actions github-actions bot added the stale label Jun 8, 2024
@sebastienros
Copy link
Member Author

We decided to accept the YT field only temporarily at the beginning of the project. A more generic field is better suited and could embed from more that just YT. The effort from the user would be the same, provide a url, so there would be no point in having both.

@hishamco
Copy link
Member

hishamco commented Jun 9, 2024

As I can see embedd can be anything Video, Audio, link, tweet .. etc, shall we support all types, by specifing the type in the admin, or showing the embedded link no matter what it was

@Piedone
Copy link
Member

Piedone commented Jun 10, 2024

A more generic field is better in terms of DRY code and for us as developers because we like such swiss Army knife things, but I doubt a normal user would understand the Ultimate Video Embedder Wizard 3000 better than the "paste YouTube URL here" field :). And then again, WP also has a YT-specific field for some reason too.

But if anybody feels that this is important, why not, just make it an additional, not substitute, field.

@hishamco
Copy link
Member

We could use a generic embedded field, and follow up to have something specific such as YouTube, Twitter .. etc

So, this means we should keep the YouTube field as its, but it SHOULD be inherited from a generic embedded field, if sound good I will start a PR

@Piedone
Copy link
Member

Piedone commented Jun 10, 2024

Sounds good. I don't think this is high on the list of priorities though.

@hishamco
Copy link
Member

Ya it's not high but at least we agree on that so we can plan then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants