-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Youtube field with a new Embedded media field #14898
Comments
Why though? If I'm a non-technical user and want to embed a YouTube video, then I'll be more comfortable using something that very clearly is for YT. WP has this too, as also shown in the video. |
Because we need a field for each embedded media service for example Vimeo |
Then it's about adding an additional field, not replacing the YT one. |
I think Seb means to replace the existing YouTube field a generic one, right? |
Yes, and hence I'm saying #14898 (comment). |
It seems that this issue didn't really move for quite a while despite us asking the author for further feedback. Is this something you'd like to revisit any time soon or should we close? Please reply. |
We decided to accept the YT field only temporarily at the beginning of the project. A more generic field is better suited and could embed from more that just YT. The effort from the user would be the same, provide a url, so there would be no point in having both. |
As I can see embedd can be anything Video, Audio, link, tweet .. etc, shall we support all types, by specifing the type in the admin, or showing the embedded link no matter what it was |
A more generic field is better in terms of DRY code and for us as developers because we like such swiss Army knife things, but I doubt a normal user would understand the Ultimate Video Embedder Wizard 3000 better than the "paste YouTube URL here" field :). And then again, WP also has a YT-specific field for some reason too. But if anybody feels that this is important, why not, just make it an additional, not substitute, field. |
We could use a generic embedded field, and follow up to have something specific such as YouTube, Twitter .. etc So, this means we should keep the YouTube field as its, but it SHOULD be inherited from a generic embedded field, if sound good I will start a PR |
Sounds good. I don't think this is high on the list of priorities though. |
Ya it's not high but at least we agree on that so we can plan then |
Orchard 1 has one.
https://learn.wordpress.org/tutorial/embedding-media-and-third-party-content-on-your-website/
The text was updated successfully, but these errors were encountered: