Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of disabling Redis SSL/TLS certificate validation #15077

Closed
ovekaaven opened this issue Jan 12, 2024 · 4 comments · Fixed by #15084
Closed

Possibility of disabling Redis SSL/TLS certificate validation #15077

ovekaaven opened this issue Jan 12, 2024 · 4 comments · Fixed by #15084
Milestone

Comments

@ovekaaven
Copy link
Contributor

ovekaaven commented Jan 12, 2024

We'd like to use "Heroku Data for Redis", which offers Redis connections with and without TLS. However, the server certificate is self-signed and the Heroku documentation states you have to disable certificate verification. This can't be done with the connection string, according to StackOverflow answers it can only be done by changing the StackExchange.Redis connection options after parsing but before connecting. But I can't find a way to do that in Orchard Core. Could it be done, or are we stuck with unencrypted Redis connections?

@MikeAlhayek
Copy link
Member

@ovekaaven you can submit a PR with a new configuration option "DisableSSLCertificate" which disables the validation after the parsing.

@ovekaaven
Copy link
Contributor Author

Ok, but if I'm supposed to write this myself it might take a while, because in order to test it I'd first have to upgrade our deployment to the newest version of Orchard Core, which probably won't happen right away. But once that happens, I can look at it if nobody else has by then, I suppose.

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Jan 12, 2024

@ovekaaven you can use the OC source and configure it to point to your Redis server for testing. Then you can make the change you want and submit a PR after you fix it.

This can be done without touching or involving your project.

@ovekaaven
Copy link
Contributor Author

I suppose you're right. I've never before tried running Orchard Core directly from its own source tree instead of from a separate project, but it turns out it's not that hard if you choose to build and run the OrchardCore.Cms.Web project within the source directory. Pull request created, hopefully it's OK.

ovekaaven added a commit to ovekaaven/OrchardCore that referenced this issue Jan 13, 2024
ovekaaven added a commit to ovekaaven/OrchardCore that referenced this issue Jan 13, 2024
ovekaaven added a commit to ovekaaven/OrchardCore that referenced this issue Jan 13, 2024
@MikeAlhayek MikeAlhayek added this to the 1.x milestone Jan 19, 2024
@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants