Migrate the OpenID module to OpenIddict 4.0 #12804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinchalet
commented
Nov 12, 2022
| principal.SetResources(await GetResourcesAsync(request.GetScopes())); | ||
| identity.SetScopes(request.GetScopes()); | ||
| identity.SetResources(await GetResourcesAsync(request.GetScopes())); | ||
| identity.SetDestinations(GetDestinations); |
There was a problem hiding this comment.
In the current bits, ExchangeClientCredentialsGrantType() doesn't use the GetDestinations() helper. This PR changes that so it also uses it, but I added a check in GetDestinations() to preserve the existing values if destinations were already attached to a claim.
kevinchalet
force-pushed
the
openiddict_4.0
branch
from
2604183
to
3a158e8
Compare
kevinchalet
commented
Dec 7, 2022
| @@ -75,34 +75,46 @@ public void Configure(OpenIddictServerOptions options) | |||
| options.SigningCredentials.Add(new SigningCredentials(key, SecurityAlgorithms.RsaSha256)); | |||
| } | |||
|
|
|||
| // Note: while endpoint paths in OrchardCore are stored as PathString instances, | |||
There was a problem hiding this comment.
More information here if you're interested in the gnarly details: openiddict/openiddict-core#1613 🤣
kevinchalet
force-pushed
the
openiddict_4.0
branch
from
8d96d16
to
48ecaea
Compare
|
OpenIddict 4.0.0 is now generally available: https://kevinchalet.com/2022/12/23/openiddict-4-0-general-availability/ 🎁 I'll merge this PR once the CI checks are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenID module to use OpenIddict 4.0 RTM, that will ship next month. Once 4.0 lands, the previous versions - including OpenIddict 3.x - will no longer be supported.
While OpenIddict 4.x itself has many internal improvements, the "public" API hasn't changed much so the changes made in this PR are mostly cosmetic.
Note: please don't merge this PR until the RTM bits are available on NuGet.org 😃