-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete code #12955
Remove obsolete code #12955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to see if we should keep them and remove them only in a major release.
Agree with @Skrypt to remove them on the next major release |
Still to remove obsolete code. |
Since we already introduce breaking changes in minor versions, which is a no-no with SemVer, why not just do it now. Any objections @Skrypt (since you added the Needs Triage label)? |
I have no objection as I approved this PR a while ago. |
I'd merge this @TFleury but there are merge conflicts. I'd also fix those but for that, you need to tick this checkbox: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests Could you please do that? I can also pull the changes and merge them from a PR of my own, but that would remove you as the author. |
@Piedone I don't have the checkbox but I solved the conflicts. |
Great, thank you! |
Remove code marked obsolete for more than two years.