Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused testing data attributes #12990

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

hishamco
Copy link
Member

No description provided.

@Skrypt
Copy link
Contributor

Skrypt commented Dec 27, 2022

Are they functional? I've not tested these environment variables but I believe they were introduced as part of the AutoSetup feature. Removing these tests may be wrong in that case.

@hishamco
Copy link
Member Author

Are they functional?

There are not references at all, FYI they introduced when we have appveyor.yml now it's not part of the repo

# Conflicts:
#	test/OrchardCore.Tests/Apis/Context/Attributes/MySqlDataAttribute.cs
#	test/OrchardCore.Tests/Apis/Context/Attributes/PostgreSqlDataAttribute.cs
#	test/OrchardCore.Tests/Apis/Context/Attributes/SqlServerDataAttribute.cs
#	test/OrchardCore.Tests/Apis/Context/Attributes/SqliteDataAttribute.cs
@hishamco hishamco merged commit 21b73cd into main Jan 5, 2023
@hishamco hishamco deleted the hishamco/test-attributes branch January 5, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants