fontawesome 6.4.0 #13233
Merged
fontawesome 6.4.0 #13233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to also update the styles as I mentioned in the previous pull request. |
agriffard
requested review from
sfmskywalker,
deanmarcussen,
kevinchalet and
hishamco
as code owners
Done. The |
|
The |
|
@agriffard interesting. It worked locally when I changed it. can we use |
|
@agriffard I think that icon is free.
|
|
Yes, it seems to be indicated thta it is available without the pro license: |
|
@agriffard I tested out this branch and everything seems to be working as expected. Are you aware of any issues or todo items here? |
|
@agriffard should we merge this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.npmjs.com/package/@fortawesome/fontawesome-free/v/6.4.0
https://github.com/FortAwesome/Font-Awesome/releases/tag/6.4.0