Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify email body #13426

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Simplify email body #13426

merged 1 commit into from
Apr 22, 2023

Conversation

hishamco
Copy link
Member

Fixes #13425

@hishamco hishamco merged commit 898eb51 into main Apr 22, 2023
@hishamco hishamco deleted the hishamco/smtp-message-body branch April 22, 2023 03:51
@MikeKry
Copy link
Contributor

MikeKry commented Nov 17, 2023

@hishamco / @sebastienros

I just came across this change after updating OC. May I ask why did we change this logic? Right now we are unable to send both html version and plain text version in one email - that is imo step in wrong direction. It should be both supported, not exclusively html / plain text.

I would suggest to revert this one, or at least revert changes inside smtp service, so we can create our own email task.. it is good practice to have both html and plain text supported.

@hishamco
Copy link
Member Author

@MikeKry can you clarify how a single email could be send in two different formats?!!

@Mike4tel
Copy link

@hishamco well, I believe that it was working all the time before like that :) look up multipart mime type for emails. It is common practice to send both variants of email. 1) it is more likely to pass through spam filters 2) there are still mail clients and users that prefer plain text.

@Mike4tel
Copy link

@hishamco
Copy link
Member Author

hishamco commented Nov 17, 2023

@Mike4tel it depends on the mail software, but while it was supported before I'm going to allow it again

@hishamco
Copy link
Member Author

FYI #14715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mail body needs to be simplified
4 participants