Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for parsing plural entries in PO files with multi line strings. #13566

Merged
merged 2 commits into from
Apr 22, 2023
Merged

Fix for parsing plural entries in PO files with multi line strings. #13566

merged 2 commits into from
Apr 22, 2023

Conversation

rros
Copy link
Contributor

@rros rros commented Apr 14, 2023 •
edited
Loading

This PR adds a test for the PoParser-class and fixes the bug in PoParser for plural entries with multi line strings.

Fixes: #13565

@rros
Copy link
Contributor Author

rros commented Apr 14, 2023

@dotnet-policy-service agree company="Blis Digital"

@rros rros changed the title Fix for Fix for parsing plural entries in PO files with multi line strings. Apr 14, 2023
@hishamco hishamco merged commit c869b77 into OrchardCMS:main Apr 22, 2023
@hishamco
Copy link
Member

Thanks for your contribution @rros

@rros rros deleted the fix-issue-13565 branch May 22, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco approved these changes

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PoParser fails to parse msgid_plural with multiline strings
3 participants
@rros @hishamco @sebastienros