Fix Functional Tests

[jtkech]

Fixes #13635
Fixes #13480

I needed to add the actions/setup-dotnet@v3 step to each test. Now it works for all databases except for MySql for which we get "max key length" errors that seem to be erroneous.

With MySql we get Specified key was too long; max key length is 3072 bytes errors when creating inner indexes in migrations, which seems erroneous, maybe it can be fixed by configuring a different char set and collation, but for now I just commented out the MySql test.

[hishamco]

Related to #13480

[sebastienros]

Why change this new code? It's displaying error messages

[sebastienros]

I tried something similar but it didn't work for me, if that's working then it's great. That's weird though that it broke at some point, maybe they have an issue with their base images.

[sebastienros]

Could it be part of the js script? Or could the js script try to perfix dotnet with this path (which is what I had tried I think).

[jtkech]

Yes, will see

Now it fails because it doesn't find powershell ;)

OCI runtime exec failed: exec failed: unable to start container process: exec: "pwsh": executable file not found in $PATH: unknown

[jtkech]

Could it be part of the js script?

I will check

[sebastienros]

Failing only with SQLServer, not sure why

[jtkech]

Because for testing I only updated the SQLServer test

So it means that we would also need to update the PATH for powershell or use directly the available command line in the containers we have initialized.

[jtkech]

@sebastienros

For info with mysql (or mariadb) some of our inner indexes keys are too long with the utf8mb4_general_ci collation which now is the default.

So to be able to use the default collation we would need to reduce some of our inner indexes keys.

Finally I could create a step to connect to the mariadb service which runs in its own container, so I needed to install mariadb-client, this to set the test database collation to utf8mb3_general_ci.

Doing this all Functional Tests work, also for MySql.

[sebastienros]

What size should the indexes be? Where should the change be done? (reducing the size of the index name)

[jtkech]

In a given inner index the total of the included columns sizes should not be greater than 3072 bytes.

So with the utf8mb4_general_ci not greater than 3072 / 4 = 768 chars.

I don't remember all the failing inner indexes but easy to retrieve.

For example the IDX_AliasPartIndex_DocumentId

        SchemaBuilder.AlterIndexTable<AliasPartIndex>(table => table
            .CreateIndex("IDX_AliasPartIndex_DocumentId",
                "DocumentId",        // bigint = 8 bytes = 2 chars.
                "Alias",             // MaxAliasLength = 740 chars.
                "ContentItemId",     // 26 chars.
                "Published",         // 1 or 2 bytes for both booleans
                "Latest")
        );                           // Total = 768 chars + (1 or 2 bytes), no luck ;)

[jtkech]

Just to say that currently all tests pass with the collation set to utf8mb3_general_ci.

But if you want I can try to reduce the size of the failing inner indexes.

[sebastienros]

We should change the name of the index to work with the defaults. At least that will make new sites work.

And existing sites that don't change the collation and upgrade their mysql version will then have to change their existing ones.

There is a limit defined in yessql AFAIR, Dean worked on that, we may need to update it there too.

[jtkech]

@sebastienros

Okay, all tests pass without having to change the MySql collation.

I jus needed to change the size of the Workflow indexes by specifying that the Ids can be limited to 26 chars, and by reducing AliasPart.MaxAliasLength from 740 to 735 chars.

Edited: For info the problem only happens when you define an inner IDX_ index, for example there is no problem with the AutoroutePartIndex for which no inner index is defined, this even if AutoroutePart.MaxPathLength = 1024.