StringExtensions Unit Tests #13657
Merged
StringExtensions Unit Tests #13657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
reviewed
May 7, 2023
| { | ||
| public class StringExtensionsTests | ||
| { | ||
| [Fact] |
There was a problem hiding this comment.
We could use Theory for both test cases 1 & 3
There was a problem hiding this comment.
Ok, using Theory in test case 1 & 3.
hishamco
requested changes
May 7, 2023
| { | ||
| [Theory] | ||
| [InlineData(new byte[]{ 10, 20, 30 }, "0A141E")] | ||
| public void ToHexString_ReturnsCorrectHexString(byte[] bytes, string expected) |
There was a problem hiding this comment.
Suggested change
| public void ToHexString_ReturnsCorrectHexString(byte[] bytes, string expected) | |
| [InlineData(new byte[0], "")] | |
| public void ToHexString_ReturnsCorrectHexString(byte[] bytes, string expected) |
test/OrchardCore.Abstractions.Tests/Modules/StringExtensionsTests.cs
Outdated
Show resolved
Hide resolved
hishamco
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing GitHub Copilot to generate Unit Tests.