Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureEventHandler base class #13687

Merged
merged 3 commits into from
May 25, 2023
Merged

FeatureEventHandler base class #13687

merged 3 commits into from
May 25, 2023

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented May 13, 2023 •
edited
Loading

To not have to define all methods when implementing IFeatureEventHandler.

As we already have with ModularTenantEvents and IModularTenantEvents.

And apply it to the current implementations.

hishamco
hishamco approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we extract the IFeatureEventHandler into another file

@sebastienros sebastienros merged commit e2c23c9 into main May 25, 2023
@sebastienros sebastienros deleted the jtkech/featureEventHandler branch May 25, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtkech @hishamco @sebastienros