Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two-factor authentication #13704

Merged
merged 14 commits into from
May 18, 2023
Merged

Add two-factor authentication #13704

merged 14 commits into from
May 18, 2023

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented May 17, 2023 •
edited
Loading

Fix #13703

2fa-settings

@MikeAlhayek MikeAlhayek marked this pull request as ready for review May 17, 2023 19:12
@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented May 17, 2023 •
edited
Loading

@jtkech you may me interested in reviewing this one. If you have time, a review is much appreciated. Hopefully @sebastienros can do a review during triage tomorrow.

@agriffard agriffard changed the title Add tow-factor authentication Add two-factor authentication May 18, 2023
hishamco
hishamco requested changes May 18, 2023
View reviewed changes
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review, suggesting few changes, I will revise the PR again

Great work Mike!!

src/OrchardCore/OrchardCore.Users.Core/Services/LoginSettingsExtensions.cs Outdated Show resolved Hide resolved
src/OrchardCore/OrchardCore.Users.Core/Services/LoginSettingsExtensions.cs Show resolved Hide resolved
src/docs/reference/modules/Users/README.md Show resolved Hide resolved
@hishamco
Copy link
Member

hishamco commented May 18, 2023 •
edited
Loading

BTW can we make the Token length a textbox instead of forcing user to select 6 or 8 digits?

@hishamco
Copy link
Member

@MikeAlhayek could you please provide a screenshot for asking for the token and possibly how to recover the missing token? Also it would be nice if you can demo it in the OC steering meeting

@MikeAlhayek
Copy link
Member Author

It was demonstrated yesterday during the meeting :).

@MikeAlhayek
Copy link
Member Author

BTW can we make the Token length a textbox instead of forcing user to select 6 or 8 digits?

No. The specification of the Authenticator apps only support 6 or 8.

@hishamco
Copy link
Member

I expect something like that :) unfortunately, I didn't attend last few meetings

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) May 18, 2023 19:18
@MikeAlhayek MikeAlhayek merged commit e295fae into OrchardCMS:main May 18, 2023
@hishamco hishamco mentioned this pull request May 18, 2023
Merged
@sebastienros
Copy link
Member

Looking at aspnetcore I don't think the user id/name is ever logged.
Example: https://github.com/dotnet/aspnetcore/blob/8aa4a527c5d0393c6d8cfc4b7f05224aae93d3f4/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Logout.cshtml.cs

@MikeAlhayek
Copy link
Member Author

I think I was looking at a code that was generated using the code generator. Either way, it be good news is that we don't log that private info also.

@Piedone Piedone mentioned this pull request May 23, 2023
Closed
@hishamco hishamco mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco requested changes

@sebastienros sebastienros sebastienros approved these changes

@agriffard agriffard Awaiting requested review from agriffard

Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for two-factor authentication
3 participants
@MikeAlhayek @hishamco @sebastienros