Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention project in the OC docs (Lombiq Technologies: OCC-167) #14795

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

porgabi
Copy link
Contributor

@porgabi porgabi commented Nov 29, 2023

@@ -192,6 +193,7 @@ nav:
- Ticket store: docs/reference/modules/Users/TicketStore.md
- Home Route: docs/reference/modules/HomeRoute/README.md
- Feeds: docs/reference/modules/Feeds/README.md
- Commerce: https://commerce.orchardcore.net/en/latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a new category such as External Modules after "Core Modules" and add Commerce there?

/cc @Piedone

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCC is kind of special because it's the only project that's officially supported (i.e. under https://github.com/OrchardCMS) but not part of OC itself. I'm OK with having it like this if it's apparent that it's not part of OC proper (which needs to be handled on https://commerce.orchardcore.net).

@Piedone Piedone changed the title OCC-167: Mention project in the OC docs Mention project in the OC docs (Lombiq Technologies: OCC-167) Jan 11, 2024
@porgabi
Copy link
Contributor Author

porgabi commented Jan 17, 2024

Not sure who to ping; can this be merged, @agriffard?

@agriffard
Copy link
Member

agriffard commented Jan 17, 2024

Okay but next time, don't mix changes that have different purposes in the same PR (Commerce link and Layer docs)

@agriffard agriffard merged commit ae2f952 into OrchardCMS:main Jan 17, 2024
3 checks passed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants