Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Multi Targets #14844

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Docker Multi Targets #14844

merged 7 commits into from
Dec 7, 2023

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Dec 6, 2023

Only for testing through github actions

@jtkech
Copy link
Member Author

jtkech commented Dec 6, 2023 •
edited
Loading

Okay using buildx and then Buildkit fails under Windows

ERROR: Error response from daemon: Windows does not support privileged mode

moby/buildkit#616

So the solution would be to deploy both images while under linux.

Edited: Okay seems to work.

So the solution to do multi targets builds is to install and use docker bluidx, but this is only possible under linux, but while under linux we now can build and push both images.

I will tweak this PR tomorrow.

@jtkech jtkech removed the don't merge label Dec 6, 2023
@jtkech jtkech changed the title Testing Docker Multi Targets Docker Multi Targets Dec 6, 2023
@jtkech jtkech merged commit 47365d6 into main Dec 7, 2023
3 checks passed
@jtkech jtkech deleted the jtkech/docker-testing branch December 7, 2023 07:21
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Closed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@jtkech @urbanit
Docker Multi Targets (OrchardCMS#14844)
33ece8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtkech