Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure AI Search (Azure Cognitive Search) #14925

Merged
merged 35 commits into from
Jan 2, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Dec 20, 2023

Fix #14906

Demo of Managing Azure AI Indices

In this demo, we enabled the Azure AI Search feature. Then created a new index for the Article content type. When creating, resetting or rebuilding and index, we trigger a job in the background that will upload all existing content items to the Azure AI Search index so the data will become searchable shortly after the action.
azure-ai-search-index

Using the Search module to search Azure AI Index

In this demo, we enabled the Search module to enable frontend search. Then used the previously created articles index as the default search index.
azure-ai-search-rearching

Search Settings Improvements

All the front end search settings are now on a single page separated by tabs.

azure-cognitive-search-2

@sebastienros
Copy link
Member

@bleroy FYI

@bleroy
Copy link
Member

bleroy commented Dec 21, 2023

Oooooh, very nice! I'll show that to the team.

@bleroy
Copy link
Member

bleroy commented Dec 21, 2023

Also, there's been a rebranding: https://azure.microsoft.com/en-us/products/ai-services/ai-search/

@hishamco
Copy link
Member

Also, there's been a rebranding: https://azure.microsoft.com/en-us/products/ai-services/ai-search/

@bleroy I just saw that while reviewing the PR, thanks for mentioning this

@MikeAlhayek seems there's another round for renaming :)

@MikeAlhayek
Copy link
Member Author

@bleroy

Also, there's been a rebranding: https://azure.microsoft.com/en-us/products/ai-services/ai-search/

Uggg. I'll rename things once I am done.

@bleroy
Copy link
Member

bleroy commented Dec 27, 2023

@MikeAlhayek > I am not sure if this is by design or an issue?

This is normal. Here's an article that describes what conditions require an index rebuild: https://learn.microsoft.com/en-us/azure/search/search-howto-reindex

@hishamco
Copy link
Member

@MikeAlhayek is this ready? I need to check the requested changes, then approve

@MikeAlhayek
Copy link
Member Author

Yes it is ready

Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't resolve the comment unless they are really resolved, I saw few formating issues that I pointed to them at the beginning

@hishamco
Copy link
Member

Again I dislike the current naming, my suggestions are

  1. OrcharcCore.Search.AzureAI
  2. OrchardCore.Search.Azure

but I'd leave this to @sebasteinros, @Piedone and other folks to decide

@MikeAlhayek
Copy link
Member Author

I am already using OrcharcCore.Search.AzureAI not planning to rename everything all over again

@hishamco
Copy link
Member

@bleroy your thought about the module name?

@Piedone
Copy link
Member

Piedone commented Jan 2, 2024

OrcharcCore.Search.AzureAI is good. The other search features use the same pattern. (And it's about "AI" search specifically.)

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) January 2, 2024 22:31
@MikeAlhayek MikeAlhayek merged commit 42837c9 into main Jan 2, 2024
3 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/cognative-search branch January 2, 2024 22:36
@hishamco
Copy link
Member

hishamco commented Jan 3, 2024

Seems you merged without a final approval, but it's fine while the name changed :)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Azure cognitive search implementation
5 participants