-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Azure AI Search (Azure Cognitive Search) #14925
Conversation
...les/OrchardCore.Search.Azure.CognitiveSearch/OrchardCore.Search.Azure.CognitiveSearch.csproj
Outdated
Show resolved
Hide resolved
...ules/OrchardCore.Search.Azure.CognitiveSearch/Views/AzureCognitiveSearchSettings.Edit.cshtml
Outdated
Show resolved
Hide resolved
...ules/OrchardCore.Search.Azure.CognitiveSearch/Views/AzureCognitiveSearchSettings.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Views/_ViewImports.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Search.Azure.CognitiveSearch.Core/Permissions.cs
Outdated
Show resolved
Hide resolved
...rchardCore.Search.Azure.CognitiveSearch.Core/Services/AzureCognitiveSearchDocumentManager.cs
Outdated
Show resolved
Hide resolved
...e/OrchardCore.Search.Azure.CognitiveSearch.Core/Services/AzureCognitiveSearchIndexManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Search.Azure.CognitiveSearch.Core/Services/SearchClientFactory.cs
Outdated
Show resolved
Hide resolved
@bleroy FYI |
Oooooh, very nice! I'll show that to the team. |
Also, there's been a rebranding: https://azure.microsoft.com/en-us/products/ai-services/ai-search/ |
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/AdminMenu.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
...les/OrchardCore.Search.Azure.CognitiveSearch/OrchardCore.Search.Azure.CognitiveSearch.csproj
Outdated
Show resolved
Hide resolved
@bleroy I just saw that while reviewing the PR, thanks for mentioning this @MikeAlhayek seems there's another round for renaming :) |
Uggg. I'll rename things once I am done. |
@MikeAlhayek > I am not sure if this is by design or an issue? This is normal. Here's an article that describes what conditions require an index rebuild: https://learn.microsoft.com/en-us/azure/search/search-howto-reindex |
@MikeAlhayek is this ready? I need to check the requested changes, then approve |
Yes it is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't resolve the comment unless they are really resolved, I saw few formating issues that I pointed to them at the beginning
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Azure.CognitiveSearch/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
Again I dislike the current naming, my suggestions are
but I'd leave this to @sebasteinros, @Piedone and other folks to decide |
I am already using |
@bleroy your thought about the module name? |
|
Seems you merged without a final approval, but it's fine while the name changed :) Thanks |
Fix #14906
Demo of Managing Azure AI Indices
In this demo, we enabled the
Azure AI Search
feature. Then created a new index for theArticle
content type. When creating, resetting or rebuilding and index, we trigger a job in the background that will upload all existing content items to the Azure AI Search index so the data will become searchable shortly after the action.Using the Search module to search Azure AI Index
In this demo, we enabled the Search module to enable frontend search. Then used the previously created
articles
index as the default search index.Search Settings Improvements
All the front end search settings are now on a single page separated by tabs.