Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Aspire host project #14961

Closed
wants to merge 10 commits into from
Closed

Adding Aspire host project #14961

wants to merge 10 commits into from

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Dec 27, 2023

Adds Aspire host project. This is a powerful project which will make development much easier since you can run just about any dependency you want like Redis...

image

@MikeAlhayek
Copy link
Member Author

@sebastienros Aspire is setup here and looks amazing.

At some point, we may want to add YARP to the CMS app so that we can run the CMS with 3 replicas and then YARP will handles distributing the requests. This would be helpful to test out app distribution services.

@MikeAlhayek
Copy link
Member Author

This PR is moving to dotnet/aspire-samples#77

@Piedone
Copy link
Member

Piedone commented Jan 17, 2024

So I guess this should be closed, with perhaps some docs suggesting people to check out the Aspire sample? And the RunAsync() changes would be useful.

@MikeAlhayek
Copy link
Member Author

Yes. I actually want to keep all the changes beside the Aspire project. I'll just need to fine time to clean it up to keep the MVC changes

@Piedone
Copy link
Member

Piedone commented Jan 17, 2024

Great then! Feel free to request my review then.

@MikeAlhayek
Copy link
Member Author

closing this PR. moved anything we would keep into PR #15115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants