Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Azure Search AI from UI or appsettings. #15004

Merged
merged 15 commits into from
Jan 10, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Jan 6, 2024

@bleroy

Made few changes here. Now you may provide settings for your Azure Search AI via UI and/or appsettings. By default, we require the user to provide service info via the UI by navigating to Configurations >> Azure AI Search.

I also added (untested) support for managed-identity for Azure Search AI. You can toggle between Default and API Key authentication type from the UI. If you are able to, can you please check out this PR and test drive it with your settings? Please test both API Key and Default I have not tested the Default type as I do not have an instances that user managed-identity.

Also, I believe I fixed the issue you encountered here #14984 (comment)

Lastly, please delete all existing indexes and create then all over again. Let me know if you run into any issue or if you find room for improvement from a user experience.

@MikeAlhayek
Copy link
Member Author

@bleroy I updated the instruction if you already read them. Here is how you can setup your own instance settings

image

In the appsettings, you may enable the configuration globally by adding this

{
  "OrchardCore":{
    "OrchardCore_AzureAISearch": {
      "Endpoint": "https://instance-id.search.windows.net",
      "IndexesPrefix":"",
      "AuthenticationType": "ApiKey",
      "DisableUIConfiguration": false,  // you can disable UI configs if you like
      "Credential": {
        "Key": "Your key"
      }
    }
  }
}

Please let me know if you are able or not to test this PR out.

@bleroy
Copy link
Member

bleroy commented Jan 8, 2024

Thanks, I'll try it sometime today or tomorrow. I'm not sure I'll be able to test MI just yet though.

@MikeAlhayek MikeAlhayek merged commit c0ed728 into main Jan 10, 2024
3 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/azure-search-cleanup branch January 10, 2024 15:18
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants