Configure JsonOptions by default #15460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the question is which one will be resolved/configured first ... since this one depends on the other. Ideally because of this dependency the DI should configure our options before, all the time. |
|
Yes they get configured during the first request at rasalution time. So first the |
dannyd89
reviewed
Mar 7, 2024
src/OrchardCore/OrchardCore.Abstractions/Json/Extensions/JsonSerializerOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Mar 7, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
This was referenced Apr 1, 2024
Sorry, it looks like there's been a lot of changes lately~~😱
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15416
@hyzx86 can you please give this PR a try to make sure the serializer is working?
@sebastienros this pr will make the default JsonOptions mirror the options we use in
JsonSerializerOptions. We could also by default useJOptions.DefaultorJOptions.Base. Thoughts?