Fixes missing dependencies in the ShellBlueprint #16379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey are not related to a specific feature. Also fixes LoadFeaturesAsync() to return the ordered features list.
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
MikeAlhayek
approved these changes
Jun 28, 2024
This was referenced Jul 1, 2024
|
Does this need triage @MikeAlhayek or can be merged? |
|
This LGTM. But another set of eye may be great. I trust @gvkries |
|
Let's check this on Thursday together. |
sebastienros
approved these changes
Jul 2, 2024
|
Let's merge it, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module contains no feature that matches the extension ID, some dependencies like startup classes were not being added to the
ShellBlueprintand therefore not executed at all.This PR fixes that by changing the
ExtensionManagerto always add every exported type to the features contained in the module. Any type that had no associated feature before, is now added to each feature as a dependency. By doing this, theCompositionStrategywill correctly find all dependencies and all startup classes are executed.Note that while working on this fix, I found another issue. The order in which startup classes are executed depends on the
ExtensionManager.LoadFeaturesAsync()method, which must already return the features in order of dependencies. However, it returns an unordered list that comes from theDictionary.Valuesproperty. I've fixed that as well, which allows us to use anotherFrozenDictionaryas a small tweak as well.This PR is based on #16324 because this change is in the same area and there is no benefit to fixing before #16324.
Fixes #16375