-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style blockquote in markdown editor #16390
Conversation
@@ -7971,6 +7971,18 @@ input[type=password]::-ms-clear { | |||
padding: 0.75rem 0.5rem; | |||
} | |||
|
|||
.EasyMDEContainer blockquote:not(.blockquote) { | |||
background: var(--bs-secondary-bg-subtle); | |||
border-left: 10px solid var(--bs-secondary-border-subtle) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduce the left border
This is an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hishamco unless the feedback address an issue with the code, I am not willing to make a change. If you think it is important, please download the branch, fix the spacing "as your soul desire" and then commit the change directly yo the branch. sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the above screenshot, I saw you fixed the issue but the border is too much, I don't want to delay your PR because I have many things to do before I get on this, if you are not in a hurry I will do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10px is what is used as a default value by many styles
Which styles you are referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant theme. here is an example of using 10px. https://www.markdownguide.org/basic-syntax/#blockquotes-1
but it does not matter as we can have our own value and it is a personal preference at the end of the day.
Fix #16389
Also, I fix side-by-side preview border colors, body color and alignment.
Here is how the preview after the fix